mirror/goirc
1
0
Fork 0
mirror of https://github.com/fluffle/goirc synced 2025-05-15 12:03:21 +00:00
Code Issues Releases Wiki Activity

New race detector finds more bugs in my crappy code :-)

Browse source
This commit is contained in:
Alex Bramley 2014-09-05 15:39:56 +01:00
parent 7c53f41c56
commit 58eaab3f1f
2 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
client/connection_test.go
View file

@ -170,6 +170,8 @@ func TestSend(t *testing.T) {
// We want to test that the a goroutine calling send will exit correctly.
exited := callCheck(t)
// send() will decrement the WaitGroup, so we must increment it.
c.wg.Add(1)
go func() {
c.send()
exited.call()
@ -224,6 +226,8 @@ func TestRecv(t *testing.T) {
// We want to test that the a goroutine calling recv will exit correctly.
exited := callCheck(t)
// recv() will decrement the WaitGroup, so we must increment it.
c.wg.Add(1)
go func() {
c.recv()
exited.call()
@ -282,6 +286,8 @@ func TestPing(t *testing.T) {
// Start ping loop.
exited := callCheck(t)
// ping() will decrement the WaitGroup, so we must increment it.
c.wg.Add(1)
go func() {
c.ping()
exited.call()
@ -349,6 +355,8 @@ func TestRunLoop(t *testing.T) {
// We want to test that the a goroutine calling runLoop will exit correctly.
// Now, we can expect the call to Dispatch to take place as runLoop starts.
exited := callCheck(t)
// runLoop() will decrement the WaitGroup, so we must increment it.
c.wg.Add(1)
go func() {
c.runLoop()
exited.call()