mirror of
https://github.com/fluffle/goirc
synced 2025-09-06 00:43:20 +00:00
8b460bc60f
70% faster when using a high number of channels Old performance ``` $ go test ./state -bench=. goos: linux goarch: amd64 pkg: github.com/fluffle/goirc/state cpu: AMD Ryzen Threadripper PRO 3945WX 12-Cores BenchmarkNickSingleChan-24 15465226 76.35 ns/op BenchmarkNickManyChan-24 5738 195721 ns/op PASS ok github.com/fluffle/goirc/state 2.433s ``` new performance ``` $ go test ./state -bench=. goos: linux goarch: amd64 pkg: github.com/fluffle/goirc/state cpu: AMD Ryzen Threadripper PRO 3945WX 12-Cores BenchmarkNickSingleChan-24 15022640 79.13 ns/op BenchmarkNickManyChan-24 10000 115104 ns/op PASS ok github.com/fluffle/goirc/state 2.456s ```
118 lines
2.8 KiB
Go
118 lines
2.8 KiB
Go
package state
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func compareNick(t *testing.T, nk *nick) {
|
|
n := nk.Nick()
|
|
if n.Nick != nk.nick || n.Ident != nk.ident || n.Host != nk.host || n.Name != nk.name ||
|
|
!n.Modes.Equals(nk.modes) || len(n.Channels) != len(nk.chans) {
|
|
t.Errorf("Nick not duped correctly from internal state.")
|
|
}
|
|
for ch, cp := range nk.chans {
|
|
if other, ok := n.Channels[ch.name]; !ok || !cp.Equals(other) {
|
|
t.Errorf("Channel not duped correctly from internal state.")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestNewNick(t *testing.T) {
|
|
nk := newNick("test1")
|
|
|
|
if nk.nick != "test1" {
|
|
t.Errorf("Nick not created correctly by NewNick()")
|
|
}
|
|
if len(nk.chans) != 0 || len(nk.lookup) != 0 {
|
|
t.Errorf("Nick maps contain data after NewNick()")
|
|
}
|
|
compareNick(t, nk)
|
|
}
|
|
|
|
func TestAddChannel(t *testing.T) {
|
|
nk := newNick("test1")
|
|
ch := newChannel("#test1")
|
|
cp := new(ChanPrivs)
|
|
|
|
nk.addChannel(ch, cp)
|
|
|
|
if len(nk.chans) != 1 || len(nk.lookup) != 1 {
|
|
t.Errorf("Channel lists not updated correctly for add.")
|
|
}
|
|
if c, ok := nk.chans[ch]; !ok || c != cp {
|
|
t.Errorf("Channel #test1 not properly stored in chans map.")
|
|
}
|
|
if c, ok := nk.lookup["#test1"]; !ok || c != ch {
|
|
t.Errorf("Channel #test1 not properly stored in lookup map.")
|
|
}
|
|
compareNick(t, nk)
|
|
}
|
|
|
|
func TestDelChannel(t *testing.T) {
|
|
nk := newNick("test1")
|
|
ch := newChannel("#test1")
|
|
cp := new(ChanPrivs)
|
|
|
|
nk.addChannel(ch, cp)
|
|
nk.delChannel(ch)
|
|
if len(nk.chans) != 0 || len(nk.lookup) != 0 {
|
|
t.Errorf("Channel lists not updated correctly for del.")
|
|
}
|
|
if c, ok := nk.chans[ch]; ok || c != nil {
|
|
t.Errorf("Channel #test1 not properly removed from chans map.")
|
|
}
|
|
if c, ok := nk.lookup["#test1"]; ok || c != nil {
|
|
t.Errorf("Channel #test1 not properly removed from lookup map.")
|
|
}
|
|
compareNick(t, nk)
|
|
}
|
|
|
|
func TestNickParseModes(t *testing.T) {
|
|
nk := newNick("test1")
|
|
md := nk.modes
|
|
|
|
// Modes should all be false for a new nick
|
|
if md.Invisible || md.Oper || md.WallOps || md.HiddenHost || md.SSL {
|
|
t.Errorf("Modes for new nick set to true.")
|
|
}
|
|
|
|
// Set a couple of modes, for testing.
|
|
md.Invisible = true
|
|
md.HiddenHost = true
|
|
|
|
// Parse a mode line that flips one true to false and two false to true
|
|
nk.parseModes("+z-x+w")
|
|
|
|
compareNick(t, nk)
|
|
if !md.Invisible || md.Oper || !md.WallOps || md.HiddenHost || !md.SSL {
|
|
t.Errorf("Modes not flipped correctly by ParseModes.")
|
|
}
|
|
}
|
|
|
|
func BenchmarkNickSingleChan(b *testing.B) {
|
|
nk := newNick("test1")
|
|
ch := newChannel("#test1")
|
|
cp := new(ChanPrivs)
|
|
nk.addChannel(ch, cp)
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
nk.Nick()
|
|
}
|
|
}
|
|
|
|
func BenchmarkNickManyChan(b *testing.B) {
|
|
const numChans = 1000
|
|
nk := newNick("test1")
|
|
for i := 0; i < numChans; i++ {
|
|
ch := newChannel(fmt.Sprintf("#test%d", i))
|
|
cp := new(ChanPrivs)
|
|
nk.addChannel(ch, cp)
|
|
}
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
nk.Nick()
|
|
}
|
|
}
|