Louis Bettens
8f773c0c79
remove implementation-specific parts in tests
2017-03-04 21:42:09 +01:00
Alex Bramley
82bcd7aded
Rename Shutdown to Close; implement io.Closer.
2016-09-16 19:40:27 +01:00
Alex Bramley
734da36009
Make Conn's Shutdown method public.
2016-09-12 20:55:10 +01:00
Alex Bramley
20e4ea9b00
TestPing needs a different timer resolution on windows. Fixes #88 .
2016-06-10 19:37:51 +01:00
Alex Bramley
0436afaf76
Contrived test for a deadlock condition.
2015-11-02 21:01:36 +00:00
Romain Soufflet
2db4b19502
Change "gomock" repository URL
2015-06-15 13:59:14 +02:00
Alex Bramley
cd24432da4
More deadlock fixes for #58 .
...
- Remove lock in Me().
- Move call to initialise() to Connect().
- Ensure DISCONNECTED event is fired after shutdown() lock is released.
2015-04-13 19:05:42 +01:00
Alex Bramley
e1ddd58df4
Update tests for deadlock fix.
2015-04-02 09:35:58 +01:00
Alex Bramley
b4870bc685
Tell state tracker all the information about Me.
2015-04-01 17:54:33 +01:00
Alex Bramley
0216e0406e
Update client for new state tracking code.
2015-01-02 12:58:50 +00:00
Alex Bramley
58eaab3f1f
New race detector finds more bugs in my crappy code :-)
2014-09-05 15:39:56 +01:00
3onyc
8f2ab20f4f
Make parseLine public by renaming it to ParseLine
2014-07-06 20:26:34 +02:00
Alex Bramley
4eaad0e95e
Use call checker instead of writing to shared var in tests (10->1).
2013-09-30 14:43:29 +01:00
Alex Bramley
637cdb573f
Put read lock in Connected() (10->9).
2013-09-30 13:55:55 +01:00
Alex Bramley
144001d109
Split handlers up into three groups.
2013-09-28 00:15:54 +01:00
Alex Bramley
5bb0c8278d
Minimally invasive change to put logging behind a user-replaceable interface.
...
This could probably be done better, and there are probably awful caveats
and hidden gotchas with this approach. I REGRET NOTHING.
2013-09-27 22:19:40 +01:00
Alex Bramley
8ae6733942
Use a channel close to kill goroutines.
...
This tidies things up nicely, especially in some of the tests.
2013-04-08 18:02:34 +01:00
Alex Bramley
0c25d2d602
Hmm, this is failing occasionally now. Maybe I need a faster computer ;-)
2013-03-10 15:51:43 +00:00
Alex Bramley
5f2665dde8
Further comment tidy and code reorg.
2013-03-10 13:16:14 +00:00
Alex Bramley
fd6fc1269b
SimpleClient shouldn't need to return an error.
2013-02-18 01:42:44 +00:00
Alex Bramley
a323372a0b
First steps towards client interface.
...
- Move all exported vars to Config struct;
- Plumbing for Config.Me etc;
- Constants and INIT/REGISTER handler from github.com/iopred;
2013-02-18 01:36:17 +00:00
Alex Bramley
b1242aa351
Break out tweakable things into a Config struct.
2013-02-16 18:05:56 +00:00
Alex Bramley
45d7b3317f
Remove state.StateTracker stutter, hide it in Conn.
2013-02-16 11:29:56 +00:00
Alex Bramley
f27e56c8b0
Run gofmt, since it's clearly been a while.
2013-02-16 10:33:15 +00:00
Alex Bramley
a674267128
Re-work Handlers for IRC events; add Commands.
2013-02-16 00:17:31 +00:00
Alex Bramley
a038856094
Remove embedded logger from client package.
2013-02-16 00:15:23 +00:00
Alex Bramley
c85f891c6b
Bah, dsymonds moved gomock again.
2012-06-26 11:20:57 +01:00
Alex Bramley
b98fabe44e
Fix go1 time changes up.
2012-06-06 17:12:07 +01:00
Alex Bramley
9c67c42fa1
Merge branch 'release'
...
Conflicts:
client/connection.go
client/connection_test.go
2012-06-06 16:25:07 +01:00
Alex Bramley
cb5001bb27
Rate limit testing was not testing properly. Needed abs() and some fixes for time changes.
2012-02-04 23:34:09 +00:00
Alex Bramley
a78aed7e7c
Functions are not comparable any more, so only compare event names.
2012-02-04 23:32:39 +00:00
Alex Bramley
6fd04236fb
"Fix" testing of ratelimiting code.
2012-02-04 01:32:48 +00:00
Alex Bramley
be271308c9
Correct import path, again.
2012-02-03 23:48:20 +00:00
Alex Bramley
8fa5e5624e
Fix issues/9 by implementing a client-side ping loop.
2011-11-15 22:17:29 +00:00
Alex Bramley
907560b599
Migrate to split event pkg.
2011-11-13 14:07:19 +00:00
Alex Bramley
4e4c4b6798
Migrate to split logging pkg.
2011-11-13 14:02:12 +00:00
Alex Bramley
f62470c091
Test rateLimit(). Move call to time.After to write() for ease of testing.
...
Complete test coverage! Well, for things that matter. I think.
2011-11-11 11:17:18 +00:00
Alex Bramley
dbc9c5f09d
Misc minor fixen.
2011-11-11 10:49:33 +00:00
Alex Bramley
dc524420b0
Test write(). Fix bug where return of Flush() was not checked.
2011-11-11 10:17:17 +00:00
Alex Bramley
19ea7138e5
Test runLoop(). Needed a lot of sleeps...
2011-11-11 09:23:12 +00:00
Alex Bramley
9ccb0a39ab
Test recv().
2011-11-11 08:35:23 +00:00
Alex Bramley
bfdd895ca6
Test send().
2011-11-11 07:59:16 +00:00
Alex Bramley
d4aceddcd7
Test Client creation and ST enable/disable.
2011-11-10 15:06:44 +00:00
Alex Bramley
a271cc06f3
Use mock dispatcher for testing event triggering.
2011-11-07 14:53:07 +00:00
Alex Bramley
aa75e0e0c6
Make enabling/disabling state-tracking easier. Improve constructors.
2011-11-07 13:34:13 +00:00
Alex Bramley
85097043cf
Epic final commit for nick/chan/logging/testing refactor.
...
* Brings logging changes to client library.
* Brings state tracker to client library.
* Rewrites all tests to use mock logger and mock state tracker.
* Makes state tracking optional, finally.
* Shaves yaks until they are almost completely bald.
2011-11-06 04:56:46 +00:00
Alex Bramley
de66051d07
Convert conn.Err into logging.
...
Also, remove all error-side-effect testing cos it was a bit shit.
First step on the long road to refactoring the nick/chan state tracking
and making everything more testable and mockable with interfaces.
2011-09-29 22:54:54 +01:00
Alex Bramley
cf8ab830f7
Move some basic assertions about initial state into setUp().
2011-08-24 13:58:00 +01:00
Alex Bramley
389f5247f5
Helpers for testing whether Conn errors are triggered.
2011-08-24 13:58:00 +01:00
Alex Bramley
7d9b8c3099
Add tests for explicit and implicit (via EOF) shutdown; fix bug ;-)
2011-08-23 10:53:52 +01:00