mirror/goirc
1
0
Fork 0
mirror of https://github.com/fluffle/goirc synced 2025-07-05 21:09:24 +00:00
Code Issues Releases Wiki Activity

handlers: check array bounds before indexing

Browse source
This commit is contained in:
John Soros 2015-11-29 04:28:05 +01:00
parent 1e190eb233
commit f0ae9bb509
3 changed files with 48 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
client/handlers.go
View file

@ -73,6 +73,9 @@ func (conn *Conn) h_433(line *Line) {
me := conn.Me()
neu := conn.cfg.NewNick(line.Args[1])
conn.Nick(neu)
if !line.argslen(1) {
return
}
// if this is happening before we're properly connected (i.e. the nick
// we sent in the initial NICK command is in use) we will not receive
// a NICK message to confirm our change of nick, so ReNick here...
@ -89,7 +92,7 @@ func (conn *Conn) h_433(line *Line) {
func (conn *Conn) h_CTCP(line *Line) {
if line.Args[0] == VERSION {
conn.CtcpReply(line.Nick, VERSION, conn.cfg.Version)
} else if line.Args[0] == PING {
} else if line.Args[0] == PING && line.argslen(2) {
conn.CtcpReply(line.Nick, PING, line.Args[2])
}
}