mirror/goirc
1
0
Fork 0
mirror of https://github.com/fluffle/goirc synced 2025-07-01 02:53:53 +00:00
Code Issues Releases Wiki Activity

NewNick handler that doesn't vary nick length. Fixes #108. Sort of.

Browse source
This commit is contained in:
Alex Bramley 2019-10-17 20:27:52 +01:00
parent 0dc1109b0d
commit b2c51c13c6
3 changed files with 53 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
client/handlers_test.go
View file

@ -1,10 +1,11 @@
package client
import (
"github.com/fluffle/goirc/state"
"github.com/golang/mock/gomock"
"testing"
"time"
"github.com/fluffle/goirc/state"
"github.com/golang/mock/gomock"
)
// This test performs a simple end-to-end verification of correct line parsing
@ -80,25 +81,26 @@ func Test433(t *testing.T) {
// Call handler with a 433 line, not triggering c.cfg.Me.Renick()
s.st.EXPECT().Me().Return(c.cfg.Me)
c.h_433(ParseLine(":irc.server.org 433 test new :Nickname is already in use."))
s.nc.Expect("NICK new_")
s.nc.Expect("NICK " + DefaultNewNick("new"))
// Send a line that will trigger a renick. This happens when our wanted
// nick is unavailable during initial negotiation, so we must choose a
// different one before the connection can proceed. No NICK line will be
// sent by the server to confirm nick change in this case.
want := DefaultNewNick(c.cfg.Me.Nick)
gomock.InOrder(
s.st.EXPECT().Me().Return(c.cfg.Me),
s.st.EXPECT().ReNick("test", "test_").Return(c.cfg.Me),
s.st.EXPECT().ReNick("test", want).Return(c.cfg.Me),
)
c.h_433(ParseLine(":irc.server.org 433 test test :Nickname is already in use."))
s.nc.Expect("NICK test_")
s.nc.Expect("NICK " + want)
// Test the code path that *doesn't* involve state tracking.
c.st = nil
c.h_433(ParseLine(":irc.server.org 433 test test :Nickname is already in use."))
s.nc.Expect("NICK test_")
s.nc.Expect("NICK " + want)
if c.cfg.Me.Nick != "test_" {
if c.cfg.Me.Nick != want {
t.Errorf("My nick not updated from '%s'.", c.cfg.Me.Nick)
}
c.st = s.st