mirror
/
goirc
mirror of https://github.com/fluffle/goirc
1
0
Fork 0
Code Issues Releases Wiki Activity

Use ExpectNothing() to make sure handlers don't generate unexpected output.

This commit is contained in:
Alex Bramley 2011-08-23 10:52:16 +01:00
parent 5ff77fc2f9
commit 770c5eb5ac
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
client/handlers_test.go
View File

@ -17,7 +17,7 @@ func TestPING(t *testing.T) {
// Test the handler for 001 / RPL_WELCOME // Test the handler for 001 / RPL_WELCOME
func Test001(t *testing.T) { func Test001(t *testing.T) {
_, c := setUp(t) m, c := setUp(t)
// Setup a mock event dispatcher to test correct triggering of "connected" // Setup a mock event dispatcher to test correct triggering of "connected"
flag := false flag := false
@ -30,6 +30,8 @@ func Test001(t *testing.T) {
// Call handler with a valid 001 line // Call handler with a valid 001 line
c.h_001(parseLine(":irc.server.org 001 test :Welcome to IRC test!ident@somehost.com")) c.h_001(parseLine(":irc.server.org 001 test :Welcome to IRC test!ident@somehost.com"))
// Should result in no response to server
m.ExpectNothing()
// Check that the event was dispatched correctly // Check that the event was dispatched correctly
if !flag { if !flag {
@ -74,7 +76,7 @@ func Test433(t *testing.T) {
// Test the handler for NICK messages // Test the handler for NICK messages
func TestNICK(t *testing.T) { func TestNICK(t *testing.T) {
_, c := setUp(t) m, c := setUp(t)
c.Debug = true c.Debug = true
// Assert that the nick set in setUp() is still "test" (just in case) // Assert that the nick set in setUp() is still "test" (just in case)
@ -84,6 +86,10 @@ func TestNICK(t *testing.T) {
// Call handler with a NICK line changing "our" nick to test1. // Call handler with a NICK line changing "our" nick to test1.
c.h_NICK(parseLine(":test!test@somehost.com NICK :test1")) c.h_NICK(parseLine(":test!test@somehost.com NICK :test1"))
// Should generate no response to server
m.ExpectNothing()
// Verify that our Nick has changed
if c.Me.Nick != "test1" { if c.Me.Nick != "test1" {
t.Errorf("NICK did not result in changing our nick.") t.Errorf("NICK did not result in changing our nick.")
} }