From d66a691370a4220f7f01a261317cd5875df81472 Mon Sep 17 00:00:00 2001 From: Michael K Date: Wed, 26 Nov 2014 15:26:17 +0100 Subject: [PATCH 1/3] Added missing punctuation marks --- feed.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/feed.go b/feed.go index 07d2537..0093c9c 100644 --- a/feed.go +++ b/feed.go @@ -104,7 +104,7 @@ type Feed struct { // New is a helper function to stay semi-compatible with // the old code. Includes the database handler to ensure // that this approach is functionally identical to the -// old databse/handlers version +// old databse/handlers version. func New(cachetimeout int, enforcecachelimit bool, ch ChannelHandlerFunc, ih ItemHandlerFunc) *Feed { db := NewDatabase() f := NewWithHandlers(cachetimeout, enforcecachelimit, NewDatabaseChannelHandler(db, ch), NewDatabaseItemHandler(db, ih)) @@ -112,8 +112,8 @@ func New(cachetimeout int, enforcecachelimit bool, ch ChannelHandlerFunc, ih Ite return f } -// NewWithHandler creates a new feed with handlers -// People should use this approach from now on +// NewWithHandler creates a new feed with handlers. +// People should use this approach from now on. func NewWithHandlers(cachetimeout int, enforcecachelimit bool, ch ChannelHandler, ih ItemHandler) *Feed { v := new(Feed) v.CacheTimeout = cachetimeout From 1dd67de72f592ac3f265c759c6db35413483b71a Mon Sep 17 00:00:00 2001 From: Michael K Date: Wed, 26 Nov 2014 16:10:39 +0100 Subject: [PATCH 2/3] Fixed typo --- feed.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/feed.go b/feed.go index 0093c9c..9ff5cd2 100644 --- a/feed.go +++ b/feed.go @@ -104,7 +104,7 @@ type Feed struct { // New is a helper function to stay semi-compatible with // the old code. Includes the database handler to ensure // that this approach is functionally identical to the -// old databse/handlers version. +// old database/handlers version. func New(cachetimeout int, enforcecachelimit bool, ch ChannelHandlerFunc, ih ItemHandlerFunc) *Feed { db := NewDatabase() f := NewWithHandlers(cachetimeout, enforcecachelimit, NewDatabaseChannelHandler(db, ch), NewDatabaseItemHandler(db, ih)) From 6c373508f8ba70f956337475849cd63113b0d7a6 Mon Sep 17 00:00:00 2001 From: Michael K Date: Wed, 26 Nov 2014 16:12:54 +0100 Subject: [PATCH 3/3] Removed faulty empty line --- feed.go | 1 - 1 file changed, 1 deletion(-) diff --git a/feed.go b/feed.go index 9ff5cd2..115c3a8 100644 --- a/feed.go +++ b/feed.go @@ -170,7 +170,6 @@ func (this *Feed) FetchClient(uri string, client *http.Client, charset xmlx.Char // This allows us to specify a custom character encoding conversion // routine when dealing with non-utf8 input. Supply 'nil' to use the // default from Go's xml package. - func (this *Feed) FetchBytes(uri string, content []byte, charset xmlx.CharsetFunc) (err error) { this.Url = uri