an
/
rss
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixes #44, crash when no handlers 

Recent database handler changes made the library crash, when feed
object is created without channel, item handlers (passing nils).
These simple changes seem to fix the problem and the library works
again.
This commit is contained in:
Paulius Maruška 2014-10-10 21:35:26 +03:00
parent c753ba0962
commit 1e531bd310
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
feed.go
View File

@ -46,13 +46,17 @@ func (err *UnsupportedFeedError) Error() string {
type ChannelHandlerFunc func(f *Feed, newchannels []*Channel) type ChannelHandlerFunc func(f *Feed, newchannels []*Channel)
func (h ChannelHandlerFunc) ProcessChannels(f *Feed, newchannels []*Channel) { func (h ChannelHandlerFunc) ProcessChannels(f *Feed, newchannels []*Channel) {
if h != nil {
h(f, newchannels) h(f, newchannels)
}
} }
type ItemHandlerFunc func(f *Feed, ch *Channel, newitems []*Item) type ItemHandlerFunc func(f *Feed, ch *Channel, newitems []*Item)
func (h ItemHandlerFunc) ProcessItems(f *Feed, ch *Channel, newitems []*Item) { func (h ItemHandlerFunc) ProcessItems(f *Feed, ch *Channel, newitems []*Item) {
if h != nil {
h(f, ch, newitems) h(f, ch, newitems)
}
} }
type Handler interface { type Handler interface {

9
feed_test.go
View File

@ -29,6 +29,15 @@ func TestFeed(t *testing.T) {
} }
} }
func Test_NoHandlers(t *testing.T) {
feed := New(1, true, nil, nil)
content, _ := ioutil.ReadFile("testdata/initial.atom")
err := feed.FetchBytes("http://example.com", content, nil)
if err != nil {
t.Error(err)
}
}
func Test_NewItem(t *testing.T) { func Test_NewItem(t *testing.T) {
content, _ := ioutil.ReadFile("testdata/initial.atom") content, _ := ioutil.ReadFile("testdata/initial.atom")
feed := New(1, true, chanHandler, itemHandler) feed := New(1, true, chanHandler, itemHandler)