an/go-pkg-rss
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #45 from Paulius-Maruska/bug/crash-without-handlers

Browse source 
Fixes #44, crash when no handlers
This commit is contained in:
Jim Teeuwen 2014-10-11 00:22:25 +02:00
commit 3d199df8a0
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
feed.go
View file

@ -46,13 +46,17 @@ func (err *UnsupportedFeedError) Error() string {
type ChannelHandlerFunc func(f *Feed, newchannels []*Channel) type ChannelHandlerFunc func(f *Feed, newchannels []*Channel)
func (h ChannelHandlerFunc) ProcessChannels(f *Feed, newchannels []*Channel) { func (h ChannelHandlerFunc) ProcessChannels(f *Feed, newchannels []*Channel) {
h(f, newchannels) if h != nil {
h(f, newchannels)
}
} }
type ItemHandlerFunc func(f *Feed, ch *Channel, newitems []*Item) type ItemHandlerFunc func(f *Feed, ch *Channel, newitems []*Item)
func (h ItemHandlerFunc) ProcessItems(f *Feed, ch *Channel, newitems []*Item) { func (h ItemHandlerFunc) ProcessItems(f *Feed, ch *Channel, newitems []*Item) {
h(f, ch, newitems) if h != nil {
h(f, ch, newitems)
}
} }
type Handler interface { type Handler interface {

9
feed_test.go
View file

@ -29,6 +29,15 @@ func TestFeed(t *testing.T) {
} }
} }
func Test_NoHandlers(t *testing.T) {
feed := New(1, true, nil, nil)
content, _ := ioutil.ReadFile("testdata/initial.atom")
err := feed.FetchBytes("http://example.com", content, nil)
if err != nil {
t.Error(err)
}
}
func Test_NewItem(t *testing.T) { func Test_NewItem(t *testing.T) {
content, _ := ioutil.ReadFile("testdata/initial.atom") content, _ := ioutil.ReadFile("testdata/initial.atom")
feed := New(1, true, chanHandler, itemHandler) feed := New(1, true, chanHandler, itemHandler)